From d63db6a05e2a62595ce273109c28989873d01407 Mon Sep 17 00:00:00 2001 From: Daz DeBoer Date: Tue, 24 May 2022 14:07:36 +0200 Subject: [PATCH] Remove unclickable buildScan link from failure Build scan links will be rendered in GHA Job Summary. --- src/cache-base.ts | 4 ---- src/execution.ts | 18 +----------------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/src/cache-base.ts b/src/cache-base.ts index 4e819c7..b8993cf 100644 --- a/src/cache-base.ts +++ b/src/cache-base.ts @@ -264,16 +264,12 @@ if (isTopLevelBuild) { def registerCallbacks(buildScanExtension, rootProjectName) { buildScanExtension.with { - def scanFile = new File("gradle-build-scan.txt") def buildFailed = false - buildFinished { result -> buildFailed = (result.failure != null) } buildScanPublished { buildScan -> - scanFile.text = buildScan.buildScanUri - // Send commands directly to GitHub Actions via STDOUT. def gradleCommand = rootProjectName + " " + gradle.startParameter.taskNames.join(" ") if (buildFailed) { diff --git a/src/execution.ts b/src/execution.ts index 369704b..cd1aa49 100644 --- a/src/execution.ts +++ b/src/execution.ts @@ -1,17 +1,9 @@ import * as core from '@actions/core' import * as exec from '@actions/exec' import fs from 'fs' -import path from 'path' import * as gradlew from './gradlew' export async function executeGradleBuild(executable: string | undefined, root: string, args: string[]): Promise { - let buildScanUrl: string | undefined - - const buildScanFile = path.resolve(root, 'gradle-build-scan.txt') - if (fs.existsSync(buildScanFile)) { - fs.unlinkSync(buildScanFile) - } - // Use the provided executable, or look for a Gradle wrapper script to run const toExecute = executable ?? gradlew.locateGradleWrapperScript(root) verifyIsExecutableScript(toExecute) @@ -20,16 +12,8 @@ export async function executeGradleBuild(executable: string | undefined, root: s ignoreReturnCode: true }) - if (fs.existsSync(buildScanFile)) { - buildScanUrl = fs.readFileSync(buildScanFile, 'utf-8') - } - if (status !== 0) { - if (buildScanUrl) { - core.setFailed(`Gradle build failed: ${buildScanUrl}`) - } else { - core.setFailed(`Gradle build failed: process exited with status ${status}`) - } + core.setFailed(`Gradle build failed: see console output for details`) } }